Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitting args for carriers to allow plating #7

Merged
merged 1 commit into from
Jun 14, 2024
Merged

splitting args for carriers to allow plating #7

merged 1 commit into from
Jun 14, 2024

Conversation

heread
Copy link
Collaborator

@heread heread commented Jun 14, 2024

Kausi added a line to split the args of the carriers (so eg ['6, 4']) into a list of strings (['6', '4']), so that plated carriers don't trigger the value error below. This allows the python frontend to generate knitout code with plating

@ixchow
Copy link
Member

ixchow commented Jun 14, 2024

Looks reasonable to me. (Though, relative to your example, it would probably split '6, 4' into ['6,', '4'].) Probably impacts discussion in issue #2, but does not resolve it.

@ixchow ixchow closed this Jun 14, 2024
@ixchow ixchow reopened this Jun 14, 2024
@ixchow ixchow merged commit 4b7599c into main Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants