Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite training for Istiod and istio 1.6+ changes #142

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

prune998
Copy link

Lots of rewrite.
Also migrate all the training on the Hipstershop application

@aditi-Kh
Copy link
Contributor

@prune998, can we update the slides in the new brand theme: https://docs.google.com/presentation/d/12zL-Cl3YK_TAY6FFCz80JJesKvA4vzYB0uwYnK9ifq4/edit?

Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this incrementally, got through the intro and security parts. Continuing as I have time.

Looks great overall, I'm mostly just going through and doing a little clean up. @tetrateio/marketing can y'all help with proof reading throughout?

modules/install/README.md Outdated Show resolved Hide resolved
modules/install/README.md Outdated Show resolved Hide resolved
Let's deploy our entire microservices application.

```shell
cd training
kubectl apply -f modules/install/app/config
kubectl create namespace hipstershopv1v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is there a reason we use hipstershopv1v2 throughout rather than hipstershop?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the hipstershop app I've created many profiles... hipstershop is a "single version" install while hipstershopv1v2 will deploy some services with v1 and v2 names...
Of course, I can change that to only use hipstershop if you think it is easier...

modules/observability/README.md Show resolved Hide resolved
modules/install/cluster/gcp.md Outdated Show resolved Hide resolved
modules/security/rbac/README.md Outdated Show resolved Hide resolved
modules/security/rbac/README.md Outdated Show resolved Hide resolved
modules/security/rbac/README.md Outdated Show resolved Hide resolved
```

If we look at the logs of the `frontend` service, we can see we still have a DENY: `could not retrieve currencies: rpc error: code = PermissionDenied desc = RBAC: access denied`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful here to look quickly at the logs on Envoy, and turn up the RBAC logs (istioctl pc log <pod> --level rbac:debug).

It would show exactly what policy failed, for example. Not super useful in these exact cases, but can be helpful for users trying to debug more complex policies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a lot more debug info there. Please review and comment. Maybe I put too much informations there... ?

modules/security/rbac/README.md Outdated Show resolved Hide resolved
@tialouden
Copy link
Contributor

tialouden commented Aug 11, 2020 via email

@ZackButcher
Copy link
Contributor

Before the upcoming training with Freddie later this month - I'm not sure the exact dates.

@prune998
Copy link
Author

Before the upcoming training with Freddie later this month - I'm not sure the exact dates.

Isn't freddie training only about TSB ?

I'll apply your review ASAP @ZackButcher
The goal would also to have 2/3 Tetrands with mixed istio knowledge go through the training from A to Z and make comments... I posted that in general slack channel but maybe someone should organize that.

@ZackButcher
Copy link
Contributor

Ah good call - yes, so reviewing this is not urgent.

prune998 and others added 2 commits August 12, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants