chore: update witness.yml with workingdir input #16
Conversation
kriscoleman
force-pushed
the
workingdir-input
branch
4 times, most recently
from
306b71b to
e229e82
Compare
|
@georgesdugue and I found more issues with this. Because of the conditional on working through some more fixes |
kriscoleman
force-pushed
the
workingdir-input
branch
3 times, most recently
from
c3d9089 to
6bea697
Compare
Added a new 'workingdir' input to the GitHub Actions workflow. This allows for specifying the working directory when running commands. The changes include: - Added 'workingdir' as an optional input in the workflow_call section. - Updated testifysec/witness-run-action usage to include 'workingdir'. - Set 'working-directory' for run commands when pull_request is true. This enhancement provides more flexibility in configuring workflows, especially when dealing with projects that have complex structures or require specific execution contexts.
kriscoleman
force-pushed
the
workingdir-input
branch
from
c237f2e to
d5390fb
Compare
|
worked through the issues
|
There was a problem hiding this comment.
Was anything actually changed in this file other than whitespace/formatting?
There was a problem hiding this comment.
I removed the default value ./ from witness-install-dir because it was already being handled in code.
I also changed how it was being handled so now it works with or without workingdir, you can see this being handled in index.js
| @@ -154,22 +136,22 @@ async function run() { | |||
|
|
|||
| if (trace) cmd.push(`--trace=${trace}`); | |||
| if (outfile) cmd.push(`--outfile=${outfile}`); | |||
| core.info("Running in directory " + process.env.GITHUB_WORKSPACE); | |||
| core.info('Running in directory ' + fullWorkspacePath); | |||
There was a problem hiding this comment.
Are these the only "real" changes in this file?
There was a problem hiding this comment.
this and lines 12-14
I found workingdir was defined but wasn't being used.
| default: 'https://archivista.testifysec.io' | ||
| required: false | ||
| type: string | ||
| workingdir: |
There was a problem hiding this comment.
oh @jkjell I also had to add workingdir here, it was missing here too
changes to get workingdir working with john's reusable workflow branch
@jkjell we have this and one other PR on your reusable workflow branch. Total that's 3 prs not merged to main that we're using in one place or another. We should get those all merged before we lose track.