Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoid support #8

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

exocode
Copy link
Contributor

@exocode exocode commented Apr 20, 2016

it implements the ability to use mongoid

@tessi
Copy link
Owner

tessi commented Apr 20, 2016

@mediatainment thanks for your pull request! I'd love to see mongoid being supported. I am currently quite busy (nobody warned me about this thing called "real life" when i was young ;)).

I will review and comment on your PR as my time allows.

@tessi tessi self-assigned this Apr 20, 2016
@tessi
Copy link
Owner

tessi commented Dec 14, 2016

@exocode I am back and currently collect changes for version 2.0.0

If you are still interested, could you please apply some changes to your PR?

  • Rebase this PR on the new master

  • Each Database module now has a little setup code:

    # lib/capistrano/uberspace/mongoid.rb
    
    module Capistrano
      module Uberspace
        module Mongoid
        end
    
        self.database_module = Mongoid
      end
    end

    This helps for auto-detecting the default database and is a potential place for common helper functions. Would be great if you'd follow that new convention.

  • Could you also please add a dump task to mongoid.rake (take inspiration from the other databases)?
    Then we'd have a database dump feature for all databases.

  • The icing on the cake would be if you could test the whole thing (when ready) on a fresh uberspace to make sure the setup code works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants