EnvironmentMonitor settings cleanup #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rjoomen
commented
Oct 4, 2023
rjoomen
commented
- Removed load() and save() methods, as properties are loaded automatically. This also gets rid of the redundant tesseract::EnvMonitor... properties in the .rviz settings file
- Moved (and unified) duplicate code to resetMonitor() method
- Only allow executing on...() methods when the correct mode is selected
- Added constants for enum propery options
- Removed onJointStateTopicChanged() from onDisplayModeChanged(), as the other on...() methods will call this anyway
…ically. This also gets rid of the redundant tesseract::EnvMonitor... properties in the .rviz settings file - Moved (and unified) duplicate code to resetMonitor() method - Only allow executing on...() methods when the correct mode is selected - Added constants for enum propery options - Removed onJointStateTopicChanged() from onDisplayModeChanged(), as the other on...() methods will call this anyway
|
@Levi-Armstrong this is probably also applicable to tesseract_ros. |
|
@dpiet this may solve some of the issues you were seeing with the Rviz loading errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.