Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make free_joint_state parsing more generalized #943

Conversation

marrts
Copy link
Contributor

@marrts marrts commented Oct 4, 2023

Fixed an issue where the IKFast plugin would fail to parse your free_joint_state list if it looked like this:

free_joint_states:
   - [0.0]
   - [-0.1]
   - [0.1]
   - [-0.2]
   - [0.2]

@Levi-Armstrong
Copy link
Contributor

Does this make sense, because this is allowing something that should a single value to be entered as a vector?

@rjoomen
Copy link
Contributor

rjoomen commented Oct 6, 2023

It is my understanding it works like this:
One free joint:

free_joint_states:
   - [0.0]
   - [-0.1]
   - [0.1]
   - [-0.2]
   - [0.2]

Two free joints:

free_joint_states:
   - [0.0, 0.0]
   - [-0.1, 0.0]
   - [0.1, 0.1]
   - [-0.2, 0.1]
   - [0.2, 0.2]

But before this PR one had to add indices:

free_joint_states:
   1: [0.0]
   2: [-0.1]
   3: [0.1]
   4: [-0.2]
   5: [0.2]

Etc.

Am I right, @marrts?

@marrts
Copy link
Contributor Author

marrts commented Oct 6, 2023

Am I right, @marrts?

Yes, that is exactly right. Now it works with either numbers or dashes. This did not effect what the actual passing of values looks like, which is how you describe it.

@Levi-Armstrong
Copy link
Contributor

Thanks for the clarification. LGTM

@marrts marrts merged commit bb547ce into tesseract-robotics:master Oct 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants