Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command serialization #1013

Conversation

Levi-Armstrong
Copy link
Contributor

There are 656 lines of serialization code within tesseract and these two line had the incorrect syntax.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (bd58a0f) to head (aae8125).

Current head aae8125 differs from pull request most recent head 103f5fc

Please upload reports for the commit 103f5fc to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   90.13%   90.13%   -0.01%     
==========================================
  Files         280      280              
  Lines       15859    15859              
==========================================
- Hits        14295    14294       -1     
- Misses       1564     1565       +1     

see 1 file with indirect coverage changes

@Levi-Armstrong Levi-Armstrong force-pushed the bugfix/command-serialization branch from aae8125 to 103f5fc Compare June 8, 2024 14:34
@Levi-Armstrong Levi-Armstrong merged commit d1ef3bc into tesseract-robotics:master Jun 8, 2024
16 of 24 checks passed
@Levi-Armstrong Levi-Armstrong deleted the bugfix/command-serialization branch June 8, 2024 15:24
@Levi-Armstrong
Copy link
Contributor Author

@johnwason Does this fix the issue you were seeing?

@johnwason
Copy link
Contributor

Still seeing the crashes and test failures

@Levi-Armstrong
Copy link
Contributor Author

Levi-Armstrong commented Jun 11, 2024

Still seeing the crashes and test failures

Does the example you posted on boost also still fail? I see your response on the boost thread so it looks like it is still happening.

@johnwason
Copy link
Contributor

I am looking at this old test case: https://github.com/johnwason/tesseract/actions/runs/8242279639

I need to find the commit locally. I will change the &= to & in this known test case and see if it makes any difference. There are too many changes in master to isolate the problem.

@johnwason
Copy link
Contributor

I didn't realize that some of the &= were in the equals functions... I changed those back and my test case is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants