Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to briefly summarize trajectory collisions #1011

Merged

Conversation

marrts
Copy link
Contributor

@marrts marrts commented Jun 3, 2024

This is to address the problem brought up here

The output looks like this:

Link Name                      Collisions
-----------------------------------------
robot_link_2                   105
robot_link_3                   95
environment_object1            64
robot_link_4                   61
environment_object2            60
environment_object3            58
environment_object4            28
environment_object5            27
environment_object6            16
environment_object7            6
environment_object8            2

This is intended to help debug if the user realizes that the haven't disabled a collision, or give the user a place to look for what might be causing problems

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (37092b7) to head (5cf57de).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   90.13%   89.86%   -0.28%     
==========================================
  Files         280      280              
  Lines       15859    15908      +49     
==========================================
  Hits        14295    14295              
- Misses       1564     1613      +49     

see 1 file with indirect coverage changes

@Levi-Armstrong Levi-Armstrong self-requested a review June 4, 2024 15:46
@Levi-Armstrong
Copy link
Contributor

Lets wait to merge until what is decided on the output from this discussion.

@marrts
Copy link
Contributor Author

marrts commented Jun 7, 2024

Changed to output something this:

                         |    0|    1|    2|    3|    4|    5|    6|
                         |-----|-----|-----|-----|-----|-----|-----|
0                env_obj1|
1            robot_link_4|   11|
2                env_obj2|    0|    0|
3            robot_link_2|  136|    0|   42|
4            robot_link_3|   14|    0|    0|    0|
5                env_obj3|    0|    0|    0|    6|    0|
6                env_obj4|    0|    0|    0|    8|    0|    0|

I chose for it to just be a bottom left triangle matrix becuase the rest of the information is redundant and with the console log we were running into a character output limit so this reduces the number of characters needed.

@Levi-Armstrong
Copy link
Contributor

LGTM, Once you have CI passing let me know and I will review.

@Levi-Armstrong Levi-Armstrong force-pushed the brief_collision_summary branch from dafc1e7 to 5cf57de Compare June 10, 2024 16:59
@Levi-Armstrong
Copy link
Contributor

@marrts I fixed the clang-tidy errors so I should be able to squash merged after CI finishes.

@Levi-Armstrong Levi-Armstrong merged commit 5bc7c44 into tesseract-robotics:master Jun 10, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants