Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WFS search #1764

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Introduce WFS search #1764

merged 1 commit into from
Dec 3, 2024

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Nov 15, 2024

This includes a generic WFS search option to the MultiSearch component while refactoring it to become no longer strongly linked to specific search engines.

Peek 2024-11-28 14-44

To activate the search engine it's sufficient to add it to the engines array in the search config of the selected instance:

{
  "name": "search",
  "config": {
    "engines": [
      "nominatim",
      "wfs"
    ]
  }
}

For a searchable layer the existing configuration is untouched and supports solr and wfs the same way:

{
  "searchable": true,
  "searchConfig": {
    "attributes": [
      "NAME",
      "scalerank"
    ],
    "displayTemplate": "Result: {NAME}"
  }
}

Additional notes:

  • this also suggests to removes the useNominatim option from the global application configurations since it's configurable by instance anyway.
  • it's now possible to configure the nominatim server URL globally.
  • the existing BasicNominatimSearch has been removed in favour of the refactored MultiSearch (having the same behaviour, but enables users to limit the search results to the given extent).

Please review @terrestris/devs.

Copy link

null

@dnlkoch dnlkoch force-pushed the introduce-wfs-search branch 2 times, most recently from c278f16 to fd0c27f Compare November 28, 2024 10:54
@dnlkoch dnlkoch force-pushed the introduce-wfs-search branch from fd0c27f to ada52b2 Compare November 28, 2024 12:45
@dnlkoch dnlkoch marked this pull request as ready for review November 28, 2024 13:45
@dnlkoch
Copy link
Member Author

dnlkoch commented Dec 3, 2024

Thanks for the review!

@dnlkoch dnlkoch merged commit 1df6014 into next Dec 3, 2024
1 check passed
@dnlkoch dnlkoch deleted the introduce-wfs-search branch December 3, 2024 15:32
Copy link

🎉 This PR is included in version 9.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants