Code

Improve golangci-lint coverage#549

Code

Merged

MusicDin merged 31 commits intoterraform-lxd:mainterraform-lxd/terraform-provider-lxd:mainfrom simondeziel:golangci-lintsimondeziel/terraform-provider-lxd:golangci-lintCopy head branch name to clipboardDec 10, 2024

+179-64

Commits

Commits on Dec 10, 2024

• Makefile: drop unneeded Go version in go mod tidy

  Show description for 8e447ff
  simondeziel

  committed
  8e447ff

• Align golangci-lint config with that of LXD

  Show description for 9852d08
  simondeziel

  committed
  9852d08

• golangci: disable exported and var-naming revive rules for now

  Show description for 9a7ad50
  simondeziel

  committed
  9a7ad50

• internal/instance/resource_instance_snapshot: simplify if/else (revive)

  Show description for 29e4e06
  simondeziel

  committed
  29e4e06

• internal/common/lxd_interface: fix comment of exported structs

  Show description for da816d1
  simondeziel

  committed
  da816d1

• internal/utils: fix comment for DiffSlices

  Show description for 64b705f
  simondeziel

  committed
  64b705f

• internal/common/lxd_exec: add comments for exported type/struct

  Show description for fa4aa91
  simondeziel

  committed
  fa4aa91

• internal/common/lxd_import: s/importId/importID/g

  Show description for 23782bb
  simondeziel

  committed
  23782bb

• internal/network/resource_network_forward: add comment to exported struct

  Show description for ea3a117
  simondeziel

  committed
  ea3a117

• internal/profile/resource_profile: add comment to exported struct

  Show description for 606fae6
  simondeziel

  committed
  606fae6

• internal/storage/resource_storage_bucket_key: add comment to exported struct

  Show description for b2bbe76
  simondeziel

  committed
  b2bbe76

• internal/storage/resource_storage_pool: add comment to exported struct

  Show description for b62e173
  simondeziel

  committed
  b62e173

• internal/storage/resource_storage_volume_copy: add comment to exported struct

  Show description for c7a8176
  simondeziel

  committed
  c7a8176

• internal/utils/buffer: add comments to exported funcs

  Show description for 52845a2
  simondeziel

  committed
  52845a2

• internal/acctest/checks: ignore conn.Close() error

  Show description for d56e40d
  simondeziel

  committed
  d56e40d

• internal/common/lxd_import: s/importId/importID/g

  Show description for 4eb2269
  simondeziel

  committed
  4eb2269

• internal/provider/provider: remove dup'ed import

  Show description for 8c66fd7
  simondeziel

  committed
  8c66fd7

• internal/instance/resource_instance_file: use named returns in splitFileResourceID()

  Show description for 71f1304
  simondeziel

  committed
  71f1304

• internal/instance/resource_instance_file: don't access slice out of bound in splitFileResourceID()

  Show description for 6722c57
  simondeziel

  committed
  6722c57

• internal/instance/resource_instance_file: no need for fmt.Sprintf() in createFileResourceID()

  Show description for 4f16d02
  simondeziel

  committed
  4f16d02

• internal/instance/resource_instance: avoid redefining new

  Show description for 44b8869
  simondeziel

  committed
  44b8869

• internal/image/resource_publish_image: check if type cast was successful

  Show description for 0933074
  simondeziel

  committed
  0933074

• internal/provider-config/config: check if type casts were successful

  Show description for ee3e210
  simondeziel

  committed
  ee3e210

• internal/provider/provider_test: ignore errors from os.Setenv/Unsetenv

  Show description for 5cb1658
  simondeziel

  committed
  5cb1658

• internal/image/resource_publish_image: name receiver

  Show description for e9a1bd2
  simondeziel

  committed
  e9a1bd2

• internal/instance/resource_instance: name receiver

  Show description for d6fd8fb
  simondeziel

  committed
  d6fd8fb

• internal/network/resource_network: name receiver

  Show description for e4740b9
  simondeziel

  committed
  e4740b9

• internal/project/resource_project: name receiver

  Show description for 6811934
  simondeziel

  committed
  6811934

• internal/storage/resource_storage_bucket: name receiver

  Show description for b6f5b7b
  simondeziel

  committed
  b6f5b7b

• internal/storage/resource_storage_pool: name receiver

  Show description for 194e210
  simondeziel

  committed
  194e210

• internal/storage/resource_storage_volume: name receivers

  Show description for e121dad
  simondeziel

  committed
  e121dad