Do not blindly accept remote certificate when using trust token #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
approved these changes
Sep 20, 2024
MusicDin
force-pushed
the
fix/token-remote-cert
branch
from
5f4fd30 to
5687f76
Compare
Sounds like its trying to do "regular" TLS verification without having the remote's |
MusicDin
force-pushed
the
fix/token-remote-cert
branch
3 times, most recently
from
73664f6 to
d4784a1
Compare
simondeziel
reviewed
Sep 20, 2024
simondeziel
reviewed
Sep 23, 2024
…trust token Signed-off-by: Din Music <[email protected]>
Reset of environment variables is already called in a defer Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/token-remote-cert
branch
from
28175ba to
d82682d
Compare
simondeziel
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #520