Allow instance rename #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
feat/instance-rename
branch
from
9beb9e2 to
fd6cc54
Compare
simondeziel
approved these changes
Sep 20, 2024
| { | ||
| // Ensure instance rename fails when instance is running. | ||
| Config: testAccInstance_rename(instanceNameA, true), | ||
| ExpectError: regexp.MustCompile("Renaming of running instance not allowed"), |
There was a problem hiding this comment.
Should we also have the resource.TestCheckResourceAttr("lxd_instance.instance1", "name", instanceNameB), checked here?
There was a problem hiding this comment.
Not sure if state is testable when error is expected, but worth trying.
There was a problem hiding this comment.
Seems to be working. Thanks :)
| }, | ||
| { | ||
| // Stop and rename the instance. | ||
| Config: testAccInstance_rename(instanceNameB, false), |
There was a problem hiding this comment.
The provided name could be a bit more indicative of the intention. Say the instance started with A, then move to A2B -> B2C -> C2D -(fail)-> D2E.
Just an idea as I think what you have is fine, it just required a bit more mental tracking.
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
feat/instance-rename
branch
from
fd6cc54 to
4e5f92b
Compare
simondeziel
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of replacing an instance, allow instance to be renamed. This is only possible if instance is either currently stopped or the
runningfield is set tofalse.