Support null values in config - from Incus #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
simondeziel
requested changes
Jul 6, 2024
Terraform allows for configuration to be set to NULL.
This is generally assumed to be equivalent to not having put the
configuration line in question and is particularly useful when dealing
with conditional behaviors.
A couple of examples:
```
resource "lxd_network" "this" {
name = "foo"
config = {
"ipv4.address" = var.deploy == "production" ? "none" : null
}
}
resource "lxd_profile" "this" {
name = "foo"
config = {
"environment.http_proxy" = var.deploy == "production" ? "http://my-proxy:3128" : null
"environment.https_proxy" = var.deploy == "production" ? "http://my-proxy:3128" : null
}
}
```
To handle this properly, a few changes are needed:
- Read the Terraform config as a map[string]*string to allow for NULL
- When set to NULL and config key doesn't exist, tell Terraform it's NULL
- When set to NULL and config key is computed, tell Terraform it's NULL
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 5f8effa895a4edb3324402c66276534750b0bb7e)
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 97258f8d4bc2bd5d58345f148f422f27c1687b5e) Signed-off-by: Din Music <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from lxc/terraform-provider-incus#82