Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine images for cached image test #475

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

MusicDin
Copy link
Member

@MusicDin MusicDin commented Jun 3, 2024

Use smaller Alpine images for testing cached images.

@MusicDin MusicDin requested a review from simondeziel June 3, 2024 15:35
@simondeziel
Copy link
Member

While in general I'm happy with smaller images, it doesn't seem to have a great influence on CI run times. Ignoring the fact they currently fail for a reason trivial to fix, the tests with the Ubuntu image would take ~11 minutes as well.

Is the speedup more noticeable locally?

@MusicDin
Copy link
Member Author

MusicDin commented Jun 3, 2024

I'm not sure why, but using ubuntu remote it occasionally takes >5min to copy an image.

For example https://github.com/terraform-lxd/terraform-provider-lxd/actions/runs/9345944914 took ~30 minutes for cached images.

For local tests it is definitely a speed up. If we want to keep ubuntu remote, I would switch the images used for cached image tests and other tests (as ubuntu image will be cached and not re-downloaded multiple times during the tests).

@MusicDin MusicDin marked this pull request as ready for review June 3, 2024 16:00
@MusicDin MusicDin added the chore label Jun 5, 2024
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, ubuntu: and other CPC maintained remotes were terribly slow (like ~500kbps) over the weekend.

@simondeziel simondeziel merged commit a32326a into terraform-lxd:main Jun 10, 2024
9 checks passed
@MusicDin MusicDin deleted the test/cached-image branch June 10, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants