Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: cleanup and catch more #364

Merged
merged 2 commits into from
Oct 30, 2023
Merged

testing: cleanup and catch more #364

merged 2 commits into from
Oct 30, 2023

Conversation

adamcstephens
Copy link
Collaborator

@adamcstephens adamcstephens commented Oct 30, 2023

reduce duplicate test runs, run more in parallel, and test building for all release platforms

build-platforms test will fail, given that Windows is already failing.

@adamcstephens adamcstephens force-pushed the gorelease/test branch 2 times, most recently from c00d8fb to 98e6165 Compare October 30, 2023 21:15
@adamcstephens adamcstephens changed the title chore: add goreleaser build to test workflow testing: reduce duplicate test runs, run more in parallel, and test building for all release platforms Oct 30, 2023
@adamcstephens adamcstephens changed the title testing: reduce duplicate test runs, run more in parallel, and test building for all release platforms testing: cleanup and catch more Oct 30, 2023
@adamcstephens
Copy link
Collaborator Author

adamcstephens commented Oct 30, 2023

Any concerns @MusicDin or @simondeziel ? I'll merge this broken and we can open another PR to fix the failing build.

Copy link
Member

@MusicDin MusicDin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll open temporary fix for Win failure.

@adamcstephens adamcstephens merged commit f129f13 into main Oct 30, 2023
3 of 4 checks passed
@adamcstephens adamcstephens deleted the gorelease/test branch October 30, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants