Determine LXD socket before retrieving a client

[MusicDin]

Instead of using LXD socket in snap's directory when an error contains /var/lib/lxd/unix.socket in the error, determine the LXD socket before retrieving the client.

[MusicDin]

@simondeziel @adamcstephens What do you think if we set TerraformLxdConfig for local during provider's initialization? This way there would be no need to set LXD_DIR/LXD_SOCKET environment variable before retrieving a client. However, I am not sure if this would have any negative implications on existing codebase..

[simondeziel]

@simondeziel @adamcstephens What do you think if we set TerraformLxdConfig for local during provider's initialization? This way there would be no need to set LXD_DIR/LXD_SOCKET environment variable before retrieving a client. However, I am not sure if this would have any negative implications on existing codebase..

I don't see any harm in exporting those 2 env variables.

[adamcstephens]

This isn’t Windows compatible so will need to be refactored. It’s blocking the release. https://github.com/terraform-lxd/terraform-provider-lxd/actions/runs/6698055575/job/18200325673