Skip to content

Commit

Permalink
fix(deps): update terraform terraform-ibm-modules/landing-zone/ibm to…
Browse files Browse the repository at this point in the history
… v6.0.1 (#206)

BREAKING CHANGE: Due to the landing zone being refactored in v6, if you are upgrading from an older version of this DA solution, VSIs will be destroyed and recreated.
  • Loading branch information
terraform-ibm-modules-ops authored Sep 26, 2024
1 parent 8184404 commit 5f8924d
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "go.sum|^.secrets.baseline$",
"lines": null
},
"generated_at": "2023-12-10T22:15:32Z",
"generated_at": "2023-12-11T22:15:32Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down
2 changes: 1 addition & 1 deletion solutions/quickstart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ To view your current configuration, run the `terraform refresh` command.

| Name | Source | Version |
|------|--------|---------|
| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 5.33.0 |
| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 6.0.1 |

### Resources

Expand Down
5 changes: 2 additions & 3 deletions solutions/quickstart/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ locals {

module "landing_zone" {
source = "terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module"
version = "5.33.0"
version = "6.0.1"
prefix = var.prefix
region = var.region
ssh_public_key = var.ssh_key
Expand Down Expand Up @@ -66,6 +66,5 @@ resource "ibm_is_instance_volume_attachment" "vsi" {
}

data "ibm_is_instance" "wazi" {
name = "${var.prefix}-workload-server-001"
depends_on = [module.landing_zone]
name = module.landing_zone.vsi_list[0].name
}
2 changes: 1 addition & 1 deletion solutions/standard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ The `override.json` file does not need to contain all elements. For example,
|------|--------|---------|
| <a name="module_client_to_site_sg"></a> [client\_to\_site\_sg](#module\_client\_to\_site\_sg) | terraform-ibm-modules/security-group/ibm | 2.6.2 |
| <a name="module_client_to_site_vpn"></a> [client\_to\_site\_vpn](#module\_client\_to\_site\_vpn) | terraform-ibm-modules/client-to-site-vpn/ibm | 1.7.20 |
| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 5.33.0 |
| <a name="module_landing_zone"></a> [landing\_zone](#module\_landing\_zone) | terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module | 6.0.1 |
| <a name="module_private_secret_engine"></a> [private\_secret\_engine](#module\_private\_secret\_engine) | terraform-ibm-modules/secrets-manager-private-cert-engine/ibm | 1.3.3 |
| <a name="module_resource_group"></a> [resource\_group](#module\_resource\_group) | terraform-ibm-modules/resource-group/ibm | 1.1.6 |
| <a name="module_secrets_manager"></a> [secrets\_manager](#module\_secrets\_manager) | terraform-ibm-modules/secrets-manager/ibm | 1.18.3 |
Expand Down
9 changes: 2 additions & 7 deletions solutions/standard/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ locals {
##############################################################################
module "landing_zone" {
source = "terraform-ibm-modules/landing-zone/ibm//patterns//vsi//module"
version = "5.33.0"
version = "6.0.1"
prefix = var.prefix
region = var.region
ssh_public_key = var.ssh_public_key
Expand Down Expand Up @@ -195,10 +195,6 @@ resource "ibm_is_security_group_rule" "s2s_security_group_inbound" {
# Additional Data volumes for Wazi VSI (Optional)
########################################################################################################################

########################################################################################################################
# Additional Data volumes for Wazi VSI (Optional)
########################################################################################################################

resource "ibm_is_instance_volume_attachment" "example" {
instance = data.ibm_is_instance.wazi.id
for_each = { for example in var.data_volume_names : example.name => example }
Expand All @@ -219,6 +215,5 @@ resource "ibm_is_instance_volume_attachment" "example" {
}

data "ibm_is_instance" "wazi" {
name = "${var.prefix}-workload-server-001"
depends_on = [module.landing_zone]
name = module.landing_zone.vsi_list[0].name
}

0 comments on commit 5f8924d

Please sign in to comment.