set default for kpk in storage delegation #223
+97
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aayush-Abhyarthi
requested review from
ocofaigh and
daniel-butler-irl
as code owners
|
@Aayush-Abhyarthi The upgrade test does not have KMS encryption enabled, so we won't be able to test this change in the upgrade test. This is a gap we probably wan't to plug before proceeding with this PR |
|
/run pipeline |
|
/run pipeline |
ocofaigh
reviewed
Dec 11, 2024
tests/pr_test.go
Outdated
| "resource_group_name": prefix, | ||
| "provider_visibility": "public", | ||
| "cos_kms_crn": terraform.Output(t, existingTerraformOptions, "key_protect_crn"), | ||
| "cos_kms_key_crn": terraform.Output(t, existingTerraformOptions, "kms_key_crn"), |
There was a problem hiding this comment.
To enable encryption, you need to set enable_cos_kms_encryption = true. The fact that the test passed even when passing values for cos_kms_crn and cos_kms_key_crn makes me think we should add variable validation to the DA code to ensure that if user does pass values for these, that enable_cos_kms_encryption has to be set to true
There was a problem hiding this comment.
It also looks like TestWithExistingKP also needs this update
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: #153
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers