feat: s2s auth iam engine #237
Open
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
requested changes
Dec 11, 2024
variables.tf
Outdated
| @@ -27,6 +27,12 @@ variable "sm_service_plan" { | |||
| } | |||
| } | |||
|
|
|||
| variable "create_iam_engine" { | |||
There was a problem hiding this comment.
The only thing getting "created" here is s2s auth policies between SM and IAM. So maybe we need to rename this to skip_iam_authorization_policy ?
The variable description needs to be more specific as to what exact type of auth policies are created (as its possible a consumer may already have them set in their account)
main.tf
Outdated
| target_service_name = "iam-identity" | ||
| roles = ["Operator"] | ||
| description = "Authorization Policy" | ||
| transaction_id = "terraformAuthorizationPolicy" |
main.tf
Outdated
| source_resource_instance_id = local.secrets_manager_guid | ||
| target_service_name = "iam-identity" | ||
| roles = ["Operator"] | ||
| description = "Authorization Policy" |
There was a problem hiding this comment.
The description needs more info as to the type of auth policy here. Check out other auth policy descrptions we have used in other modules for an idea
main.tf
Outdated
| source_resource_instance_id = local.secrets_manager_guid | ||
| target_service_name = "iam-groups" | ||
| roles = ["Groups Service Member Manage"] | ||
| description = "Authorization Policy" |
There was a problem hiding this comment.
same as above, description needs to be updated
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding IAM engine to the main module. It is also the new default behavior. Not sure if this should qualify for a major release.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers