fix: add prefix to en topics and email subscription #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
akocbek
previously approved these changes
Aug 16, 2024
|
/run pipeline |
|
/run pipeline |
iamar7
changed the title
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
@ocofaigh this PR is making sure the topics and email subscription are unique when a user is provisioning multiple scc instance with the same event notification but this is not the fix for #162 where |
|
OK thanks, FYI, the error in the tests will be fixed in #152 so once thats merged, we can rebase this PR |
|
/run pipeline |
ocofaigh
approved these changes
Sep 4, 2024
|
🎉 This PR is included in version 1.17.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added prefix to EN subscription email name & topic to make sure these property are unique.
Resolves: #172
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This release add prefix to event notification subscription email name & topic to make sure these property are unique.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers