-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the ability to define the scope of SCC attachement #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh @jor2 The new inputs need to be added to ibm_catalog.json
- you should make the attachment_schedule
a dropdown with the supported values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for some descriptions. Let me know if they don't make sense.
updated, is that what you meant by dropdown? |
ibm_catalog.json
Outdated
@@ -92,6 +92,27 @@ | |||
} | |||
] | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the order of the variables here matter, as thats the order they show in the UI. We try to group related variables together. You after adding this between kms_endpoint_type
and scc_cos_key_ring_name
which are both KMS related vars. Can you group the attachment related variables together. You also need to add resource_groups_scope
too so it gets ordered
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve, but I think this might need attention:
ibm_cloud.json
support_details
: Should probably use the one we put in security-services:
If you’re experiencing issues with this product, review the troubleshooting information available from the “Docs” link in the Related links section. If you can’t resolve your problem, click “Get help” in the related links and create a case.
@SirSpidey The |
🎉 This issue has been resolved in version 1.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add the ability to define the scope of SCC attachement
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Add the ability to define the scope of SCC attachement
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers