Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to define the scope of SCC attachement #148

Merged
merged 11 commits into from
Jul 24, 2024
Merged

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Jul 8, 2024

Description

Add the ability to define the scope of SCC attachement

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add the ability to define the scope of SCC attachement

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jul 8, 2024
@jor2 jor2 requested review from ocofaigh and akocbek as code owners July 8, 2024 21:37
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

solutions/instances/variables.tf Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
@ocofaigh
Copy link
Member

@jor2 you may also want to consider including this change too #149

@jor2
Copy link
Member Author

jor2 commented Jul 22, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jul 22, 2024

/run pipeline

@jor2 jor2 requested a review from ocofaigh July 23, 2024 00:04
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jor2 can you check my comment?

@jor2 jor2 requested a review from SirSpidey July 23, 2024 13:52
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh @jor2 The new inputs need to be added to ibm_catalog.json - you should make the attachment_schedule a dropdown with the supported values

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for some descriptions. Let me know if they don't make sense.

solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
solutions/instances/variables.tf Outdated Show resolved Hide resolved
Jordan-Williams2 added 2 commits July 23, 2024 18:57
@jor2 jor2 requested review from SirSpidey and ocofaigh July 23, 2024 18:01
@jor2
Copy link
Member Author

jor2 commented Jul 23, 2024

Oh @jor2 The new inputs need to be added to ibm_catalog.json - you should make the attachment_schedule a dropdown with the supported values

updated, is that what you meant by dropdown?

ibm_catalog.json Outdated
@@ -92,6 +92,27 @@
}
]
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order of the variables here matter, as thats the order they show in the UI. We try to group related variables together. You after adding this between kms_endpoint_type and scc_cos_key_ring_name which are both KMS related vars. Can you group the attachment related variables together. You also need to add resource_groups_scope too so it gets ordered

@jor2
Copy link
Member Author

jor2 commented Jul 24, 2024

/run pipeline

@jor2 jor2 requested a review from ocofaigh July 24, 2024 10:20
@jor2
Copy link
Member Author

jor2 commented Jul 24, 2024

/run pipeline

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but I think this might need attention:

ibm_cloud.json

If you’re experiencing issues with this product, review the troubleshooting information available from the “Docs” link in the Related links section. If you can’t resolve your problem, click “Get help” in the related links and create a case.

@ocofaigh
Copy link
Member

@SirSpidey The support_details were added to all of the DAs in the community registry. There is no cloud docs to link to for those DAs. And they are not supported through support cases as they are not in main catalog

@ocofaigh ocofaigh merged commit 98e7fd6 into main Jul 24, 2024
2 checks passed
@ocofaigh ocofaigh deleted the scope-feat branch July 24, 2024 15:37
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants