Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional Watson assistant access policies #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

in-1911
Copy link
Contributor

@in-1911 in-1911 commented Sep 20, 2024

Description

  • Optionally add access policies targeting Watson assistant resources created by the DA (assistant, skills, environment)
    • The target use case: multiple teams are deploying their stack configuration, using the same Watson Assistant service instance and only will get editor access to the assistant "workspace" that their stack deployment creates.
    • Policies are added to an existing access group named in existing_wa_access_group_name parameter
    • The group is likely to be configured to include other access policies related to the solution deployment, so it's not quite practical to create a new access group at this point
    • Watson resource access roles are set to "Reader", "Writer", "Viewer", "Editor"
    • Uses terraform-ibm-iam-access-group module
  • Fix for uppercase characters in prefix that would cause a validation error with Elastic index

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@in-1911 in-1911 requested review from ocofaigh and removed request for brendankellyibm September 20, 2024 01:54
@in-1911
Copy link
Contributor Author

in-1911 commented Sep 20, 2024

/run pipeline

@in-1911
Copy link
Contributor Author

in-1911 commented Sep 20, 2024

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant