Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: exposed the ability to set the provider_visibility in DA" and plugged test gaps #930

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Dec 11, 2024

Description

This reverts commit a6c87a4. and plugs test gaps mentioned in issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

reverts the ability to expose provider_visibility as there is a bug when setting the provider visibility to private related to resource tags and also plugs test gaps related to it

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16 Aditya-ranjan-16 changed the title Revert "feat: exposed the ability to set the provider_visibility in DA" Revert "feat: exposed the ability to set the provider_visibility in DA" and plugged test gaps Dec 11, 2024
@Aditya-ranjan-16 Aditya-ranjan-16 marked this pull request as ready for review December 11, 2024 09:25
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

The upgrade test failed with:

Error: UpgradeVsiExtention 2024-12-11T10:08:19Z logger.go:66: │ Error: [ERROR] Error Fetching vpc An error occurred while performing the 'authenticate' step: Post "https://private.us-east.iam.cloud.ibm.com/identity/token": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

This is expected, and its the reason why we are reverting the code. Going to force merge this PR

@ocofaigh ocofaigh merged commit e2d5345 into main Dec 11, 2024
1 of 2 checks passed
@ocofaigh ocofaigh deleted the revert-921-provider_visibility branch December 11, 2024 13:32
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[terraform-ibm-landing-zone] Revert provider visibility change and plug test gap
3 participants