Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: Integrate ocp-base with SLZ #253

Closed
wants to merge 166 commits into from
Closed

[WIP] feat: Integrate ocp-base with SLZ #253

wants to merge 166 commits into from

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Jan 11, 2023

Description

Please include a summary of the change and which issue is fixed. Also, please include the motivation and context for the change. List any dependencies that are required for this change.

Issue : #324

Check the relevant boxes:

  • Bug fix (nonbreaking change that fixes an issue)
  • New feature (nonbreaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI related update (pipeline, etc.)

Checklist

  • If relevant, a test for the change has been added or updated as part of this PR.
  • If relevant, documentation for the change has been added or updated as part of this PR.

Merge

  • Merge using "Squash and merge".
  • Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

Release notes content

https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/blob/extend-output/.docs/update-version.md

@Aashiq-J Aashiq-J marked this pull request as ready for review January 11, 2023 16:28
@vburckhardt vburckhardt changed the title test: extend output to support ocp [WIP] test: extend output to support ocp Jan 16, 2023
@Aashiq-J Aashiq-J requested review from vburckhardt and removed request for vburckhardt January 24, 2023 17:25
@Aashiq-J Aashiq-J requested a review from vburckhardt January 24, 2023 21:33
@Aashiq-J Aashiq-J changed the title [WIP] test: extend output to support ocp [WIP] feat: Integrate ocp-all-inclusive with SLZ Feb 2, 2023
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Aashiq-J - thanks for the PR.

I think the approach should be as follows:

cluster.tf Outdated Show resolved Hide resolved
ocp-all-inclusive/main.tf Outdated Show resolved Hide resolved
ocp-all-inclusive/main.tf Outdated Show resolved Hide resolved
@Aashiq-J Aashiq-J requested a review from vburckhardt March 1, 2023 15:38
@Aashiq-J Aashiq-J requested a review from toddgiguere as a code owner June 27, 2024 06:26
@ocofaigh ocofaigh closed this Sep 26, 2024
@ocofaigh ocofaigh deleted the extend-output branch September 26, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants