-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: Integrate ocp-base with SLZ #253
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vburckhardt
changed the title
test: extend output to support ocp
[WIP] test: extend output to support ocp
Jan 16, 2023
Aashiq-J
requested review from
vburckhardt
and removed request for
vburckhardt
January 24, 2023 17:25
Aashiq-J
changed the title
[WIP] test: extend output to support ocp
[WIP] feat: Integrate ocp-all-inclusive with SLZ
Feb 2, 2023
vburckhardt
reviewed
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Aashiq-J - thanks for the PR.
I think the approach should be as follows:
- Create new repos under terraform-ibm-module for the ocp-all-inclusive, ocp-base, ocp-observability-agent modules. This is the same repo structure as we currently have internally. The idea here is to enable the use of those modules on top of SLZ VPCs, but also usable on top of any VPC, including the VPC structure used internally
- In the ocp-all-inclusive example folder, have an example of deploying the ocp-all-inclusive module on top of an existing SLZ VPC. See the VSI example here https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/blob/main/examples/default/main.tf as a source of inspiration. You could use https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/tree/main/examples/no-compute-example as a base to create the VPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Also, please include the motivation and context for the change. List any dependencies that are required for this change.
Issue : #324
Check the relevant boxes:
Checklist
Merge
Release notes content
https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/blob/extend-output/.docs/update-version.md