-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:exposing CBRs in DA #594
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget when adding a new input variable to a DA, it needs to go into ibm_catalog.json too so it can be ordered.
Also this PR is missing supporting markdown doc which the variable descrption needs to point to. We already have one in this repo here, so you should update that
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments.
@Aditya-ranjan-16, also please link the GIT issue in this PR description. |
/run pipeline |
/run pipeline |
Description
Exposed CBRs in DA
GIT Issue
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Exposes CBRs in DA
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers