Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:exposing CBRs in DA #594

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat:exposing CBRs in DA #594

wants to merge 9 commits into from

Conversation

Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Dec 4, 2024

Description

Exposed CBRs in DA

GIT Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Exposes CBRs in DA

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 changed the title feat:Exposing CBRs in DA feat:exposing CBRs in DA Dec 4, 2024
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget when adding a new input variable to a DA, it needs to go into ibm_catalog.json too so it can be ordered.

Also this PR is missing supporting markdown doc which the variable descrption needs to point to. We already have one in this repo here, so you should update that

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Copy link
Member

@Ak-sky Ak-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments.

solutions/standard/DA-types.md Outdated Show resolved Hide resolved
solutions/standard/DA-types.md Outdated Show resolved Hide resolved
solutions/standard/DA-types.md Outdated Show resolved Hide resolved
solutions/standard/DA-types.md Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member

Ak-sky commented Dec 11, 2024

@Aditya-ranjan-16, also please link the GIT issue in this PR description.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants