Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fixes around input DA variables #305

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

akocbek
Copy link
Contributor

@akocbek akocbek commented Sep 30, 2024

Description

Issue: #297

  • existing_kms_key_crn is currently in the required list but should be moved to optiona
  • move use_existing_resource_group next to resource_group_name in ui (on required).
  • elser_model_type -> this is only applicable if plan is platinum (not for enterprise). At minumum indicate it in the description of the variable.
  • skip_es_sm_auth_policy -> use full service name when they are not obvious to typical end-user (skip_elastic_search_secret_manager_auth_policy or skip_elastic_search_to_secret_manager_auth_policy)
  • existing_db_instance_crn -> use elastic_search instead of db for consistency in naming.
  • skip_iam_authorization_policy and skip_es_sm_auth_policy are inconsistent in term of naming.
  • group related inputs together in ui - eg: all kms related input together.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek
Copy link
Contributor Author

akocbek commented Sep 30, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elasticsearch is one word, so personally I would remove the underscores from the variable names. Feel free to ask other team members what they think though

@akocbek
Copy link
Contributor Author

akocbek commented Oct 3, 2024

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Oct 3, 2024

   "Result": {
        	            	│         "errors": [
        	            	│             {
        	            	│                 "code": "zone_used_by_rule",
        	            	│                 "message": "The network zone '53e58ce8397c1fbc6b61497b734effa5' is referenced by one or more rules and cannot be deleted."
        	            	│        

rerunning

@akocbek
Copy link
Contributor Author

akocbek commented Oct 3, 2024

/run pipeline

@ocofaigh
Copy link
Member

@akocbek what happened to this one? Is it good to go? If so, can you update the release notes section of the PR description and get pipeline passing please?

@akocbek
Copy link
Contributor Author

akocbek commented Dec 9, 2024

/run pipeline

1 similar comment
@akocbek
Copy link
Contributor Author

akocbek commented Dec 9, 2024

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants