-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: small fixes around input DA variables #305
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elasticsearch
is one word, so personally I would remove the underscores from the variable names. Feel free to ask other team members what they think though
/run pipeline |
rerunning |
/run pipeline |
@akocbek what happened to this one? Is it good to go? If so, can you update the release notes section of the PR description and get pipeline passing please? |
/run pipeline |
1 similar comment
/run pipeline |
Description
Issue: #297
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers