Skip to content

Commit

Permalink
feat: The default value of retention_enabled has changed from `true…
Browse files Browse the repository at this point in the history
…` to `false`. Any consumers who are upgrading to this version and want retention enabled must now explicitly set `retention_enabled = true` when consuming (#421)
  • Loading branch information
iamar7 authored Jun 30, 2023
1 parent 7efbcbd commit 220e9c3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ You need the following permissions to run this module.
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID where resources will be provisioned. | `string` | n/a | yes |
| <a name="input_resource_key_existing_serviceid_crn"></a> [resource\_key\_existing\_serviceid\_crn](#input\_resource\_key\_existing\_serviceid\_crn) | CRN of existing serviceID to bind with resource key to be created. If null a new ServiceID is created for the resource key. | `string` | `null` | no |
| <a name="input_retention_default"></a> [retention\_default](#input\_retention\_default) | Specifies default duration of time an object that can be kept unmodified for COS bucket. Only used if 'create\_cos\_bucket' is true. | `number` | `90` | no |
| <a name="input_retention_enabled"></a> [retention\_enabled](#input\_retention\_enabled) | Retention enabled for COS bucket. Only used if 'create\_cos\_bucket' is true. | `bool` | `true` | no |
| <a name="input_retention_enabled"></a> [retention\_enabled](#input\_retention\_enabled) | Retention enabled for COS bucket. Only used if 'create\_cos\_bucket' is true. | `bool` | `false` | no |
| <a name="input_retention_maximum"></a> [retention\_maximum](#input\_retention\_maximum) | Specifies maximum duration of time an object that can be kept unmodified for COS bucket. Only used if 'create\_cos\_bucket' is true. | `number` | `350` | no |
| <a name="input_retention_minimum"></a> [retention\_minimum](#input\_retention\_minimum) | Specifies minimum duration of time an object must be kept unmodified for COS bucket. Only used if 'create\_cos\_bucket' is true. | `number` | `90` | no |
| <a name="input_retention_permanent"></a> [retention\_permanent](#input\_retention\_permanent) | Specifies a permanent retention status either enable or disable for COS bucket. Only used if 'create\_cos\_bucket' is true. | `bool` | `false` | no |
Expand Down
2 changes: 1 addition & 1 deletion module-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
"name": "retention_enabled",
"type": "bool",
"description": "Retention enabled for COS bucket. Only used if 'create_cos_bucket' is true.",
"default": true,
"default": false,
"pos": {
"filename": "variables.tf",
"line": 151
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ variable "management_endpoint_type_for_bucket" {
variable "retention_enabled" {
description = "Retention enabled for COS bucket. Only used if 'create_cos_bucket' is true."
type = bool
default = true
default = false
}

variable "retention_default" {
Expand Down

0 comments on commit 220e9c3

Please sign in to comment.