Skip to content

Commit

Permalink
fix: bump required ibm provider version to >=1.51.0 to ensure fix is …
Browse files Browse the repository at this point in the history
…in that allows the replication rule to replicate to/from buckets with numerics in the name (#255)
  • Loading branch information
shemau authored Mar 7, 2023
1 parent 1638d82 commit 20f03c0
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ You need the following permissions to run this module.
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.49.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.51.0 |
| <a name="requirement_null"></a> [null](#requirement\_null) | >=3.2.1 |

## Modules
Expand Down
2 changes: 1 addition & 1 deletion examples/complete/version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Pin to the lowest provider version of the range defined in the main module to ensure lowest version still works
ibm = {
source = "ibm-cloud/ibm"
version = "1.49.0"
version = "1.51.0"
}
# The restapi provider is not actually required by the module itself, just this example, so OK to use ">=" here instead of locking into a version
restapi = {
Expand Down
2 changes: 1 addition & 1 deletion examples/existing-resources/version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Pin to the lowest provider version of the range defined in the main module to ensure lowest version still works
ibm = {
source = "ibm-cloud/ibm"
version = "1.49.0"
version = "1.51.0"
}
# The restapi provider is not actually required by the module itself, just this example, so OK to use ">=" here instead of locking into a version
restapi = {
Expand Down
10 changes: 4 additions & 6 deletions examples/replication/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ module "resource_group" {

# Create COS source bucket
module "cos_source_bucket" {
source = "../../"
# bucket_name = "${var.prefix}-bucket-source" # temporary override to match ibm_cos_bucket_replication_rule regex
bucket_name = "cos-replicate-bucket-source"
source = "../../"
bucket_name = "${var.prefix}-bucket-source"
resource_group_id = module.resource_group.resource_group_id
region = var.region
cos_instance_name = "${var.prefix}-source-cos"
Expand All @@ -27,9 +26,8 @@ module "cos_source_bucket" {

# Create COS target bucket
module "cos_target_bucket" {
source = "../../"
# bucket_name = "${var.prefix}-bucket-target" # temporary override to match ibm_cos_bucket_replication_rule regex
bucket_name = "cos-replicate-bucket-target"
source = "../../"
bucket_name = "${var.prefix}-bucket-target"
resource_group_id = module.resource_group.resource_group_id
region = var.region
cos_instance_name = "${var.prefix}-target-cos"
Expand Down
2 changes: 1 addition & 1 deletion examples/replication/version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Pin to the lowest provider version of the range defined in the main module to ensure lowest version still works
ibm = {
source = "ibm-cloud/ibm"
version = "1.49.0"
version = "1.51.0"
}
}
}
2 changes: 1 addition & 1 deletion module-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@
"ibm": {
"source": "ibm-cloud/ibm",
"version_constraints": [
"\u003e= 1.49.0"
"\u003e= 1.51.0"
]
},
"null": {
Expand Down
2 changes: 1 addition & 1 deletion version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Use "greater than or equal to" range in modules
ibm = {
source = "ibm-cloud/ibm"
version = ">= 1.49.0"
version = ">= 1.51.0"
}
null = {
source = "hashicorp/null"
Expand Down

0 comments on commit 20f03c0

Please sign in to comment.