generated from terraform-ibm-modules/stack-ibm-template
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profile attachments to DA stack #121
Closed
Changes from 5 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
77f1ef1
feat: add profile attachments to DA
2f8adf1
feat: add profile attachments to DA
229ee43
Merge branch 'main' into scc-feat
jor2 0c015da
fix: version locator
jor2 9ce3306
Merge branch 'main' into scc-feat
vburckhardt d8b5e3d
fix: address feedback
73f6238
Merge branch 'scc-feat' of github.com:terraform-ibm-modules/stack-ret…
622a302
fix: address feedback
f52d4b3
fix: failure
b123936
fix: failure
c4ae4b0
Merge branch 'main' of github.com:terraform-ibm-modules/stack-retriev…
74faeaa
Merge branch 'main' into scc-feat
jor2 761ccfa
Merge branch 'main' into scc-feat
jor2 f14241c
Merge branch 'main' into scc-feat
jor2 3a188e0
Merge branch 'main' into scc-feat
jor2 3709e37
Merge branch 'main' into scc-feat
jor2 3a396dc
fix: repo
d30d482
fix: add prefix to scc
255de3b
fix: add prefix to scc
eaddc14
fix: add prefix to scc
9acbc79
fix: add prefix to scc
adf45d8
fix: add prefix to scc
62a945b
feat: add more vars
ce0d927
feat: add more vars
bff3ff5
feat: add more vars
c7819cf
feat: add more vars
3a8ddd0
feat: add more vars
580fcec
Update ibm_catalog.json
jor2 5d2a013
feat: add more vars
fd68890
Merge branch 'scc-feat' of github.com:terraform-ibm-modules/stack-ret…
850706d
fix: var type
e977a28
Merge branch 'main' into scc-feat
jor2 5731b7c
Merge branch 'main' into scc-feat
jor2 e1ec6d7
Merge branch 'main' into scc-feat
jor2 7ec510b
Merge branch 'main' into scc-feat
jor2 e64418e
Update stack_definition.json
jor2 c8bbd56
Update stack_definition.json
jor2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,6 +61,13 @@ | |
"hidden": false, | ||
"default": null | ||
}, | ||
{ | ||
"name": "profile_attachments", | ||
"required": false, | ||
"type": "list(string)", | ||
"hidden": false, | ||
"default": ["IBM Cloud Framework for Financial Services"] | ||
}, | ||
{ | ||
"name": "enable_platform_logs_metrics", | ||
"required": false, | ||
|
@@ -190,7 +197,7 @@ | |
}, | ||
{ | ||
"name": "2c - Security Service - Security Compliance Center", | ||
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.9e036202-5495-4ea3-926b-3751450bbf54-global", | ||
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.8d3300b4-b36b-4226-bf1c-b634cfc30b2c-global", | ||
"inputs": [ | ||
{ | ||
"name": "ibmcloud_api_key", | ||
|
@@ -212,6 +219,10 @@ | |
"name": "existing_kms_instance_crn", | ||
"value": "ref:../2a - Security Service - Key Management/outputs/kms_instance_crn" | ||
}, | ||
{ | ||
"name": "profile_attachments", | ||
"value": "ref:../../inputs/profile_attachments" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Set the default here - point to the AI ICT Guardrails (as opposed to fs cloud) as this is what we're claiming in the stack. |
||
}, | ||
{ | ||
"name": "use_existing_resource_group", | ||
"value": true | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not expose this input directly at the top level of the stack as it is unlikely to be common to change it.