Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile attachments to DA stack #121

Closed
wants to merge 37 commits into from
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
77f1ef1
feat: add profile attachments to DA
Jun 4, 2024
2f8adf1
feat: add profile attachments to DA
Jun 4, 2024
229ee43
Merge branch 'main' into scc-feat
jor2 Jun 5, 2024
0c015da
fix: version locator
jor2 Jun 5, 2024
9ce3306
Merge branch 'main' into scc-feat
vburckhardt Jun 12, 2024
d8b5e3d
fix: address feedback
Jun 13, 2024
73f6238
Merge branch 'scc-feat' of github.com:terraform-ibm-modules/stack-ret…
Jun 13, 2024
622a302
fix: address feedback
Jun 13, 2024
f52d4b3
fix: failure
Jun 13, 2024
b123936
fix: failure
Jun 13, 2024
c4ae4b0
Merge branch 'main' of github.com:terraform-ibm-modules/stack-retriev…
Jun 19, 2024
74faeaa
Merge branch 'main' into scc-feat
jor2 Jun 24, 2024
761ccfa
Merge branch 'main' into scc-feat
jor2 Jul 1, 2024
f14241c
Merge branch 'main' into scc-feat
jor2 Jul 8, 2024
3a188e0
Merge branch 'main' into scc-feat
jor2 Jul 19, 2024
3709e37
Merge branch 'main' into scc-feat
jor2 Jul 22, 2024
3a396dc
fix: repo
Jul 22, 2024
d30d482
fix: add prefix to scc
Jul 22, 2024
255de3b
fix: add prefix to scc
Jul 22, 2024
eaddc14
fix: add prefix to scc
Jul 22, 2024
9acbc79
fix: add prefix to scc
Jul 22, 2024
adf45d8
fix: add prefix to scc
Jul 22, 2024
62a945b
feat: add more vars
Jul 24, 2024
ce0d927
feat: add more vars
Jul 24, 2024
bff3ff5
feat: add more vars
Jul 24, 2024
c7819cf
feat: add more vars
Jul 24, 2024
3a8ddd0
feat: add more vars
Jul 24, 2024
580fcec
Update ibm_catalog.json
jor2 Jul 25, 2024
5d2a013
feat: add more vars
Jul 25, 2024
fd68890
Merge branch 'scc-feat' of github.com:terraform-ibm-modules/stack-ret…
Jul 25, 2024
850706d
fix: var type
Jul 25, 2024
e977a28
Merge branch 'main' into scc-feat
jor2 Jul 29, 2024
5731b7c
Merge branch 'main' into scc-feat
jor2 Aug 20, 2024
e1ec6d7
Merge branch 'main' into scc-feat
jor2 Aug 30, 2024
7ec510b
Merge branch 'main' into scc-feat
jor2 Sep 2, 2024
e64418e
Update stack_definition.json
jor2 Sep 2, 2024
c8bbd56
Update stack_definition.json
jor2 Sep 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ibm_catalog.json
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,13 @@
"default_value": "__NULL__",
"description": "The CRN of an existing KMS instance to use in this solution. If not set, a new KP instance is provisioned.",
"required": false
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not expose this input directly at the top level of the stack as it is unlikely to be common to change it.

"key": "profile_attachments",
"type": "list(string)",
"default_value": ["IBM Cloud Framework for Financial Services"],
"description": "Optional list of SCC profile attachments to create that will be scoped to your specific IBM Cloud account with a `daily` attachment schedule and defaults to the latest version of the specified profile attachments.",
"required": false
}
],
"outputs": [
Expand Down
13 changes: 12 additions & 1 deletion stack_definition.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@
"hidden": false,
"default": null
},
{
"name": "profile_attachments",
"required": false,
"type": "list(string)",
"hidden": false,
"default": ["IBM Cloud Framework for Financial Services"]
},
{
"name": "enable_platform_logs_metrics",
"required": false,
Expand Down Expand Up @@ -190,7 +197,7 @@
},
{
"name": "2c - Security Service - Security Compliance Center",
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.9e036202-5495-4ea3-926b-3751450bbf54-global",
"version_locator": "7a4d68b4-cf8b-40cd-a3d1-f49aff526eb3.8d3300b4-b36b-4226-bf1c-b634cfc30b2c-global",
"inputs": [
{
"name": "ibmcloud_api_key",
Expand All @@ -212,6 +219,10 @@
"name": "existing_kms_instance_crn",
"value": "ref:../2a - Security Service - Key Management/outputs/kms_instance_crn"
},
{
"name": "profile_attachments",
"value": "ref:../../inputs/profile_attachments"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the default here - point to the AI ICT Guardrails (as opposed to fs cloud) as this is what we're claiming in the stack.

},
{
"name": "use_existing_resource_group",
"value": true
Expand Down