-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: add instances_details sensitive output #308
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Any plans to merge this soon? |
Hi @matusso - Please visit https://cla.developers.google.com so we can review this PR. Thanks! |
@apeabody done |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
/gcbrun |
Added sensitive = true for instances_details
could it be possible to finally close it? come on, I know u r big company, processes & stuff, but you should be able to close one-line merge request |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @matusso!
Added sensitive = true for instances_details to avoid following error.
Error: Output refers to sensitive values
│
│ on outputs.tf line 22:
│ 22: output "instances_details" {
│
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│ sensitive = true