Added conditional check for outlier detection applied to specific lb …

…schemes
terraform-google-modules · Nov 6, 2023 · 1969b2b · 1969b2b
1 parent 56da382
commit 1969b2b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/autogen/main.tf.tmpl b/autogen/main.tf.tmpl
@@ -287,7 +287,7 @@ resource "google_compute_backend_service" "default" {
   }
 
   dynamic "outlier_detection" {
-    for_each = each.value.outlier_detection != null ? [1] : []
+    for_each = each.value.outlier_detection != null && ( var.load_balancing_scheme == "INTERNAL_SELF_MANAGED" || var.load_balancing_scheme == "EXTERNAL_MANAGED" ) ? [1] : []
     content {
       consecutive_errors                    = each.value.outlier_detection.consecutive_errors
       consecutive_gateway_failure           = each.value.outlier_detection.consecutive_gateway_failure

diff --git a/main.tf b/main.tf
@@ -278,7 +278,7 @@ resource "google_compute_backend_service" "default" {
   }
 
   dynamic "outlier_detection" {
-    for_each = each.value.outlier_detection != null ? [1] : []
+    for_each = each.value.outlier_detection != null && (var.load_balancing_scheme == "INTERNAL_SELF_MANAGED" || var.load_balancing_scheme == "EXTERNAL_MANAGED") ? [1] : []
     content {
       consecutive_errors                    = each.value.outlier_detection.consecutive_errors
       consecutive_gateway_failure           = each.value.outlier_detection.consecutive_gateway_failure

diff --git a/modules/dynamic_backends/main.tf b/modules/dynamic_backends/main.tf
@@ -278,7 +278,7 @@ resource "google_compute_backend_service" "default" {
   }
 
   dynamic "outlier_detection" {
-    for_each = each.value.outlier_detection != null ? [1] : []
+    for_each = each.value.outlier_detection != null && (var.load_balancing_scheme == "INTERNAL_SELF_MANAGED" || var.load_balancing_scheme == "EXTERNAL_MANAGED") ? [1] : []
     content {
       consecutive_errors                    = each.value.outlier_detection.consecutive_errors
       consecutive_gateway_failure           = each.value.outlier_detection.consecutive_gateway_failure

diff --git a/modules/serverless_negs/main.tf b/modules/serverless_negs/main.tf
@@ -266,7 +266,7 @@ resource "google_compute_backend_service" "default" {
   }
 
   dynamic "outlier_detection" {
-    for_each = each.value.outlier_detection != null ? [1] : []
+    for_each = each.value.outlier_detection != null && (var.load_balancing_scheme == "INTERNAL_SELF_MANAGED" || var.load_balancing_scheme == "EXTERNAL_MANAGED") ? [1] : []
     content {
       consecutive_errors                    = each.value.outlier_detection.consecutive_errors
       consecutive_gateway_failure           = each.value.outlier_detection.consecutive_gateway_failure