Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove fuse csi driver from autopilot #2218

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: remove fuse csi driver from autopilot #2218

wants to merge 3 commits into from

Conversation

DrFaust92
Copy link
Contributor

Fuse CSI Driver is not supported for autopilot

@DrFaust92 DrFaust92 requested review from ericyz and a team as code owners December 17, 2024 00:20
@apeabody
Copy link
Collaborator

From the lint test:

terraform_validate ./examples/simple_autopilot_public
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 52, in module "gke":
│   52:   gcs_fuse_csi_driver             = true
│ 
│ An argument named "gcs_fuse_csi_driver" is not expected here.

@apeabody apeabody self-assigned this Dec 18, 2024
@apeabody
Copy link
Collaborator

This can be included in v35.0.1

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

Fuse CSI Driver is not supported for autopilot

For clarify: "The Cloud Storage FUSE CSI driver is enabled by default for Autopilot clusters."

@apeabody
Copy link
Collaborator

/gcbrun

apeabody
apeabody reviewed Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

Given the removal of the variable for Autopilot clusters, I think we'll want to classify this as a breaking change. Thoughts? Otherwise this LGTM.

@apeabody apeabody added the blocked Blocked by some other work label Dec 24, 2024
@DrFaust92
Copy link
Contributor Author

apeabody Im fine with as i prefer err on the side of caution. but I dont think its breaking as it not supported toggle anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody left review comments

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@apeabody apeabody

Labels
blocked Blocked by some other work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @apeabody