fix(monitoring_config): 🐛 enable/disable observability inputs & logmon_config_is_set

[Markieta]

• Adds monitoring_enable_observability_relay as per google_container_cluster.
• Change logmon_config_is_set to check for observability inputs as well.
  • fixes No changes detected when adding observability_metrics inputs to existing cluster modules. #1892
• Sets the following inputs to null instead of false to support disabling existing pre-enabled features via Terraform:
  • monitoring_enable_managed_prometheus
  • monitoring_enable_observability_metrics
  • monitoring_enable_observability_relay

[bharathkkb]

/gcbrun

[matthisholleville]

Can't wait to use this PR !!

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[apeabody]

Thanks for the contribution @Markieta!

Can you please rebase the PR, and we'll do a fresh run of the CI tests.

[Markieta]

Hope my commits struggling to rebase/merge is not a problem. 😅

Should be good to test now.

[apeabody]

Hope my commits struggling to rebase/merge is not a problem. 😅

Should be good to test now.

No problem at all, we squash into a single commit on merge.

[apeabody]

/gcbrun

[apeabody]

From the CI tests:

TestBetaCluster 2024-05-30T18:32:07Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; 
Error: Missing required argument

  with module.this.module.gke.google_container_cluster.primary,
  on ../../../modules/beta-public-cluster/cluster.tf line 22, in resource "google_container_cluster" "primary":
  22: resource "google_container_cluster" "primary" {

The argument
"monitoring_config.0.advanced_datapath_observability_config.0.enable_metrics"
is required, but no definition was found.}

[Markieta]

I wasn't able to replicate the issue with docker_test_integration but I think I know what's going wrong.

I've replaced "enableRelay": false with "enableMetrics": false as the latter is required by the google_container_cluster resource (though unsure if it's sufficient to only update TestBetaCluster.json/TestSimpleRegional.json with enableMetrics.)

[apeabody]

/gcbrun

[SavvasM1]

Why is this build failing? Would love to see this guy in sooner than later :)

[apeabody]

From the test:

        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Missing required argument
        	            	
        	            	  with module.example.module.gke.google_container_cluster.primary,
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 22, in resource "google_container_cluster" "primary":
        	            	  22: resource "google_container_cluster" "primary" {
        	            	
        	            	The argument
        	            	"monitoring_config.0.advanced_datapath_observability_config.0.enable_metrics"
        	            	is required, but no definition was found.}
        	Test:       	TestSandboxEnabled

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[slimatic]

can this be bumped?

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days