Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support aws_grafana_license_association.grafana_token #43

Merged

Conversation

magreenbaum
Copy link
Member

Description

Support grafana_token.
Ran some terraform plans with this new argument but difficult for me to actually test.

Motivation and Context

Closes: #37
hashicorp/terraform-provider-aws#38743
hashicorp/terraform-provider-aws#38775

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit ce90f62 into terraform-aws-modules:master Nov 1, 2024
6 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 1, 2024
## [2.3.0](v2.2.1...v2.3.0) (2024-11-01)

### Features

* Support `aws_grafana_license_association.grafana_token` ([#43](#43)) ([ce90f62](ce90f62))
@antonbabenko
Copy link
Member

This PR is included in version 2.3.0 🎉

@magreenbaum magreenbaum deleted the feat/grafana_token branch November 1, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GrafanaToken option on aws_grafana_workspace resources
3 participants