Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: avoid using the highest byte of pointer #22911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

licy183
Copy link
Member

@licy183 licy183 commented Jan 13, 2025

Closes #22907

@Biswa96
Copy link
Member

Biswa96 commented Jan 13, 2025

Could you share how you find the cause of the issue and debug it?

@licy183
Copy link
Member Author

licy183 commented Jan 14, 2025

Could you share how you find the cause of the issue and debug it?

./build-package.sh -i firefox -d, lldb -- firefox, and then bt to get the stack trace.

@truboxl
Copy link
Contributor

truboxl commented Jan 14, 2025

I get Segmentation Fault right after open firefox

@813ethan
Copy link
Contributor

813ethan commented Jan 14, 2025

is this the cause of the issue tho? the definition for kHighBit doesn't have the __ANDROID__ safeguards and the code relevant to it seems to also be there in v133.0.3 (release date dec 10) which the bug didn't happen

https://github.com/mozilla/gecko-dev/commits/master/layout/generic/IntrinsicISizesCache.h

@licy183
Copy link
Member Author

licy183 commented Jan 14, 2025

https://salsa.debian.org/mozilla-team/firefox/-/tree/upstream/133.0.3

layout/generic/IntrinsicISizesCache.h doesn't exist in 133.0.3.

@813ethan
Copy link
Contributor

fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gah. your tab just crashed. (Firefox 134 - XFCE4 - X11/NON-PROOT)
4 participants