Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new example gen remote zip file csv example gen #130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

avnyadav
Copy link

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@github-actions
Copy link
Contributor

Thanks for the PR! 🚀

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

@casassg
Copy link
Member

casassg commented Apr 15, 2022

Hey! Thanks for the contribution. That said, a couple general comments:

  • Please use the pre-commit hook to format code in the same way as the rest of the codebase. See contributing.md for this.
  • Structure should be tfx_addons/{project_name}

@casassg
Copy link
Member

casassg commented Apr 18, 2022

Separately, @Avnish327030 did you submit a proposal document as explained in README - https://github.com/tensorflow/tfx-addons#project-approvals

Copy link
Collaborator

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit a project proposal for review - https://github.com/tensorflow/tfx-addons/blob/main/CONTRIBUTING.md#project-proposals

Also, the file hierarchy should match the convention for TFX-Addons. Please refer to the other projects for examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants