ci(bazel): simplify scripts and configuration in advance of additions #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the Bazel-related CI scripts and BUILD configuration in preparation for adding several more for the compression feature. - Move CC=clang to .bazelrc - Define CXX in case it's already defined in the environment, in which case it overrides deferring to CC - Replace --repo_env, which doesn't affect build, with --action_env - Move commented-out ubsan invocation to its own CI job. Since ubsan was commented out, Bazel invocations have moved to their own jobs so they can run in parallel. - Consistently test all targets, `...`, since TFLM is no longer confined to the tensorflow/lite/micro directory. Filter out inappropriate new targets with no.san tags. - Don't run `bazel build ...` before `bazel test ...`; the latter already builds all non-test targets. - Remove obsolete filter for `no_oss`, there were no more `no_oss` tags in the tree. - Stop using readable_run: it has diverged from its original meaning and now only redirects stderr to stdout. This is not needed. BUG=see description
rkuester
requested review from
advaitjain,
rockyrhodes,
suleshahid and
a team
as code owners
suleshahid
reviewed
Nov 20, 2024
Clarify that the scripts run from the root directory of the project by restoring the change of directory at the top of the script, even though CI runs from the root directory of the project. Also clarify the intention that all tests in the project be run by specifying `//...`, rather than `...`, which means all targets at or below the working directory.
suleshahid
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the Bazel-related CI scripts and BUILD configuration in
preparation for adding several more for the compression feature.
Move CC=clang to .bazelrc
Define CXX in case it's already defined in the environment, in
which case it overrides deferring to CC
Replace --repo_env, which doesn't affect build, with --action_env
Move commented-out ubsan invocation to its own CI job. Since
ubsan was commented out, Bazel invocations have moved to their
own jobs so they can run in parallel.
Consistently test all targets,
..., since TFLM is no longerconfined to the tensorflow/lite/micro directory. Filter out
inappropriate new targets with no.san tags.
Don't run
bazel build ...beforebazel test ...; the latteralready builds all non-test targets.
Remove obsolete filter for
no_oss, there were no moreno_osstags in the tree.Stop using readable_run: it has diverged from its original
meaning and now only redirects stderr to stdout. This is not
needed.
BUG=see description