Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSC cl/683332949 - Move initializers into constructors. #6927

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

arcra
Copy link
Member

@arcra arcra commented Oct 16, 2024

Move the initializer into the constructor for instance members that reference identifiers declared in the constructor.

Googlers, see cl/683332949 for more details.

arcra added 2 commits October 16, 2024 21:30
… members that reference identifiers declared in the constructor.
@arcra arcra requested a review from rileyajones October 16, 2024 23:46
@rileyajones
Copy link
Contributor

Do you mind testing importing this?

@arcra
Copy link
Member Author

arcra commented Oct 17, 2024

Do you mind testing importing this?

Not at all. Here's the presubmit run: cl/686693513

@arcra arcra merged commit 109771f into tensorflow:master Oct 17, 2024
13 checks passed
@arcra arcra deleted the fix_initializers_cl_683332949 branch October 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants