Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sync errors #6739

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fixes sync errors #6739

merged 2 commits into from
Feb 1, 2024

Conversation

hoonji
Copy link
Member

@hoonji hoonji commented Jan 31, 2024

Motivation for features / changes

Recently merged hparam column PRs (#6732, #6733, #6736) will cause build and lint errors during 1p sync.

Technical description of changes

  • import map from rxjs/operators instead of rxjs
  • DataTableUtils -> dataTableUtils
  • use proper string signature on CardStateMap in tests

@hoonji hoonji requested a review from rileyajones January 31, 2024 15:33
Copy link
Contributor

@rileyajones rileyajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal lint rules are different from the external ones and there are examples of them being mutually incompatible so we typically assume the sync will not pass lint and will merge it anyway.

@hoonji hoonji merged commit 933f37a into tensorflow:master Feb 1, 2024
13 checks passed
@hoonji
Copy link
Member Author

hoonji commented Feb 1, 2024

The internal lint rules are different from the external ones and there are examples of them being mutually incompatible so we typically assume the sync will not pass lint and will merge it anyway.

Thanks for the context, it's good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants