Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCMigration: Style runs data table row heights for MDC migration. #6616

Merged
merged 1 commit into from
Oct 4, 2023
Merged

MDCMigration: Style runs data table row heights for MDC migration. #6616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tensorboard/webapp/metrics/views/card_renderer/scalar_card_data_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ limitations under the License.
==============================================================================*/
$_circle-size: 12px;

tb-data-table-content-cell,
tb-data-table-header-cell {
padding: 4px;
}

.row-circle {
height: $_circle-size;
width: $_circle-size;
Expand Down
4 changes: 3 additions & 1 deletion tensorboard/webapp/runs/views/runs_table/runs_data_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@ $_arrow_size: 16px;

tb-data-table-content-row,
tb-data-table-header-cell {
height: 44px;
// Match the size of the touch targets for the checkbox.
height: 48px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish the touch target would match our size like all the other parts of mdc-checkbox do. I am ok with this though.

}

tb-data-table-content-cell,
tb-data-table-header-cell {
padding: 0 4px;
vertical-align: middle;
@include tb-theme-foreground-prop(border-bottom, border, 1px solid);

Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/widgets/data_table/content_cell_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ limitations under the License.

:host {
display: table-cell;
padding: 4px;
}

.cell {
align-items: center;
display: flex;
Expand Down
1 change: 0 additions & 1 deletion tensorboard/webapp/widgets/data_table/header_cell_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ $_icon_size: 12px;

:host {
display: table-cell;
padding: 4px;
vertical-align: bottom;

&:hover {
Expand Down