Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug Fix: Fix color picker regression (#6682)
## Motivation for features / changes There was a regression associated with the new runs table which meant that changing the color of a run immediately closed the color picker. ## Technical description of changes Previously the runs table did not have a dependency on the metrics state. Now that it does, changing the color of a run leads to a state change which then in turn rerenders the row and thus closed the color picker. The state dependency is important so that cannot be undone, however, we don't actually need to re render the rows when the color changes so I've update the render logic to ignore the `color` attribute (I know it's a little hacky). ## Screenshots of UI changes (or N/A) Before: ![45503b0a-11af-4660-b168-fb54b6262a00](https://github.com/tensorflow/tensorboard/assets/78179109/f08dd518-1b0e-4287-b933-87c1d4f374d1) After - With Paint Flashing ![9c5d3e86-9369-4c37-87ab-66bb74662c07](https://github.com/tensorflow/tensorboard/assets/78179109/26176959-c196-4d5b-923d-8686c4264dce) After - Without Paint Flashing ![57df4fe5-536a-49f0-aeda-16028912e35b](https://github.com/tensorflow/tensorboard/assets/78179109/bd098ea7-4cac-4b01-961d-ee7203f5a7f2) ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Open the color picker 3) Change the color 4) Observe the color picker does not close 5) Check a row and observe that it is rerendered. ## Alternate designs / implementations considered (or N/A)
- Loading branch information