Fix the Cifar10ImagePreprocessor class to use newer dataset APIs #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedwm
requested changes
Jan 17, 2020
| capacity=min_queue_examples + 3 * self.batch_size, | ||
| min_after_dequeue=min_queue_examples) | ||
|
|
||
| dataset_train = dataset_train.shuffle(min_queue_examples).batch( |
There was a problem hiding this comment.
You should call .repeat() in between shuffle and batch
| dataset_train = dataset_train.shuffle(min_queue_examples).batch( | ||
| self.batch_size, drop_remainder=True) | ||
|
|
||
| if tf.VERSION > "1.12": |
There was a problem hiding this comment.
You can safely assume TensorFlow is at least version 1.12. There are branches such as cnn_tf_v1.11_compatible that work with older versions.
| self.batch_size, drop_remainder=True) | ||
|
|
||
| if tf.VERSION > "1.12": | ||
| raw_images, raw_labels = tf.compat.v1.data.make_one_shot_iterator( |
There was a problem hiding this comment.
No need for compat.v1 since we have import tensorflow.compat.v1 as tf at the top. Simply tf.data.make_one_shot_iterator is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding the issue #313.