-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a feature to allow get and set of license from Tenable SC #845
base: main
Are you sure you want to change the base?
Conversation
… Center objects. This is used for automation since we install and rehydrate our environments from source periodically.
This pull request addresses a git issue I just opened #848 so please let me know if there is anything I can do to help move this forward! Thank you @mark-carey-sap for adding this; we really could benefit from it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently missing any unit tests for the proposed module. Otherwise looks good.
Constancy is good. Agreed. Co-authored-by: Steven McGrath <[email protected]>
Consistency is good. Agreed. Co-authored-by: Steven McGrath <[email protected]>
I'm at a bit of a loss on how to Unit test this one. It would require a valid license to make any sense of the responses. If you have a way that I'm not seeing, please let me know and I'll be happy to implement it. We could certainly test for the expected failure, but success is the check that matters 😁 . Thanks for considering this one. |
Following up on this pull request to see if we can get this into main or clarity regarding how to create unit tests for this sort of a capability. |
I do not think you’d need a valid license, simply some dummy data to ensure some of the responses are accurate. The newer tests with the responses library are great examples. I am currently on PTO this week, so if you need specific examples I can get them to you next week. |
Added a feature to allow get and set of license from/to Tenable SC objects. This is used for automation since we install and rehydrate our environments from source periodically.
Description
This is a simple patch to expose licensing functionality for automation. It adds a license API object to the main Tenable SC object and provides a simple get/set method to allow the examination and setting of licenses in a non-GUI way.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: