rename dynamic config

temporalio · Nov 30, 2024 · 8cec945 · 8cec945
1 parent 0584967
commit 8cec945
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 9 deletions.
diff --git a/common/dynamicconfig/constants.go b/common/dynamicconfig/constants.go
@@ -852,10 +852,12 @@ of Timeout and if no activity is seen even after that the connection is closed.`
 		true,
 		`FrontendEnableSchedules enables schedule-related RPCs in the frontend`,
 	)
-	FrontendEnableDeployments = NewNamespaceBoolSetting(
-		"frontend.enableDeployments",
+	EnableDeployments = NewNamespaceBoolSetting(
+		"system.enableDeployments",
 		false,
-		`FrontendEnableDeployments enables deployment-related RPCs in the frontend`,
+		`EnableDeployments enables deployments (versioning v3) in all services,
+including deployment-related RPCs in the frontend, deployment entity workflows in the worker,
+and deployment interaction in matching and history.`,
 	)
 	EnableNexus = NewGlobalBoolSetting(
 		"system.enableNexus",

diff --git a/service/frontend/service.go b/service/frontend/service.go
@@ -309,7 +309,7 @@ func NewConfig(
 
 		EnableSchedules: dynamicconfig.FrontendEnableSchedules.Get(dc),
 
-		EnableDeployments: dynamicconfig.FrontendEnableDeployments.Get(dc),
+		EnableDeployments: dynamicconfig.EnableDeployments.Get(dc),
 
 		EnableBatcher:                   dynamicconfig.FrontendEnableBatcher.Get(dc),
 		MaxConcurrentBatchOperation:     dynamicconfig.FrontendMaxConcurrentBatchOperationPerNamespace.Get(dc),

diff --git a/service/matching/config.go b/service/matching/config.go
@@ -214,7 +214,7 @@ func NewConfig(
 		TestDisableSyncMatch:                     dynamicconfig.TestMatchingDisableSyncMatch.Get(dc),
 		LoadUserData:                             dynamicconfig.MatchingLoadUserData.Get(dc),
 		HistoryMaxPageSize:                       dynamicconfig.MatchingHistoryMaxPageSize.Get(dc),
-		EnableDeployments:                        dynamicconfig.FrontendEnableDeployments.Get(dc),
+		EnableDeployments:                        dynamicconfig.EnableDeployments.Get(dc),
 		MaxTaskQueuesInDeployment:                dynamicconfig.MatchingMaxTaskQueuesInDeployment.Get(dc),
 		RPS:                                      dynamicconfig.MatchingRPS.Get(dc),
 		OperatorRPSRatio:                         dynamicconfig.OperatorRPSRatio.Get(dc),

diff --git a/service/worker/deployment/fx.go b/service/worker/deployment/fx.go
@@ -93,7 +93,7 @@ func NewResult(
 	return fxResult{
 		Component: &workerComponent{
 			activityDeps: params,
-			enabledForNs: dynamicconfig.FrontendEnableDeployments.Get(dc),
+			enabledForNs: dynamicconfig.EnableDeployments.Get(dc),
 		},
 	}
 }

diff --git a/tests/deployment_test.go b/tests/deployment_test.go
@@ -84,7 +84,7 @@ func TestDeploymentSuite(t *testing.T) {
 func (s *DeploymentSuite) SetupSuite() {
 	s.setAssertions()
 	dynamicConfigOverrides := map[dynamicconfig.Key]any{
-		dynamicconfig.FrontendEnableDeployments.Key():                  true,
+		dynamicconfig.EnableDeployments.Key():                          true,
 		dynamicconfig.FrontendEnableWorkerVersioningDataAPIs.Key():     true,
 		dynamicconfig.FrontendEnableWorkerVersioningWorkflowAPIs.Key(): true,
 		dynamicconfig.FrontendEnableWorkerVersioningRuleAPIs.Key():     true,

diff --git a/tests/versioning_3_test.go b/tests/versioning_3_test.go
@@ -82,7 +82,7 @@ func TestVersioning3FunctionalSuite(t *testing.T) {
 
 func (s *Versioning3Suite) SetupSuite() {
 	dynamicConfigOverrides := map[dynamicconfig.Key]any{
-		dynamicconfig.FrontendEnableDeployments.Key():                  true,
+		dynamicconfig.EnableDeployments.Key():                          true,
 		dynamicconfig.FrontendEnableWorkerVersioningWorkflowAPIs.Key(): true,
 		dynamicconfig.MatchingForwarderMaxChildrenPerNode.Key():        partitionTreeDegree,
 

diff --git a/tests/versioning_test.go b/tests/versioning_test.go
@@ -86,7 +86,7 @@ func TestVersioningFunctionalSuite(t *testing.T) {
 
 func (s *VersioningIntegSuite) SetupSuite() {
 	dynamicConfigOverrides := map[dynamicconfig.Key]any{
-		dynamicconfig.FrontendEnableDeployments.Key():                  true,
+		dynamicconfig.EnableDeployments.Key():                          true,
 		dynamicconfig.FrontendEnableWorkerVersioningDataAPIs.Key():     true,
 		dynamicconfig.FrontendEnableWorkerVersioningWorkflowAPIs.Key(): true,
 		dynamicconfig.FrontendEnableWorkerVersioningRuleAPIs.Key():     true,