Skip to content

Commit

Permalink
Fix write start time to execution info (#6590)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
Populate StartTime in mutable state execution info

## Why?
<!-- Tell your future self why have you made these changes -->
We cannot delete from there yet: downgrade breaks.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Start with change, and downgrade temporal works as it should.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
  • Loading branch information
rodrigozhou authored Oct 2, 2024
1 parent 722c497 commit 428f71a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions service/history/workflow/mutable_state_impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ func NewMutableState(

LastCompletedWorkflowTaskStartedEventId: common.EmptyEventID,

StartTime: timestamppb.New(startTime),
VersionHistories: versionhistory.NewVersionHistories(&historyspb.VersionHistory{}),
ExecutionStats: &persistencespb.ExecutionStats{HistorySize: 0},
SubStateMachinesByType: make(map[string]*persistencespb.StateMachineMap),
Expand Down

0 comments on commit 428f71a

Please sign in to comment.