Make ctor for DefaultPayloadConverter public to expose JsonSerializerOptions
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rOptions` Resolves temporalio#225.
cretz
reviewed
Apr 21, 2024
cretz
approved these changes
Apr 22, 2024
cretz
reviewed
Apr 22, 2024
| @@ -87,7 +79,6 @@ protected DefaultPayloadConverter(params IEncodingConverter[] encodingConverters | |||
|
|
|||
| // KeyedCollection not worth it and OrderedDictionary not generic. So we'll expose the | |||
| // collection and maintain an internal dictionary. | |||
|
|
|||
There was a problem hiding this comment.
Looks like this line removal broke lint check, may need to add it back. Also note since I merged main into your branch, you'll want to pull before making this change.
There was a problem hiding this comment.
@cretz mobile edits ftw :)
Should be good for you to retrigger CI
ElanHasson
commented
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #225.
What was changed
Made the ctor for
DefaultPayloadConverterpublic to exposeJsonSerializerOptions.Why?
This is to allow customizing the json serializer without creating a new Payload Converter and incurring additional configuration overhead.
Checklist
Closes [Feature Request] Make protected DefaultPayloadConverter constructors public #225
How was this tested:
The compiler + existing tests.
Any docs updates needed?
Do not think so. Maybe worth a mention of this capability via Sample request: Custom converter samples-dotnet#38