Remove unused shipment status 'id' field #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasek
requested changes
Sep 10, 2024
There was a problem hiding this comment.
@tomwheeler think we can get rid of id here and cleanup fulfillments.svelte since when the event listener got moved out it's not used here anymore.
tomwheeler
changed the title
|
I removed the id prop in both places, we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I removed the shipment status ID.
Why?
When testing a PR #10, submitted by Phil Prasek, I found that Svelte issued a warning:
One of the changes in that PR eliminated the use of the shipment status ID field. Since the field is no longer being used, this PR removes that field altogether.
Checklist
I observed the warning before the change. I made the change and then observed that the warning disappeared. In either case, I was able to successfully submit and process both single- and multi-item orders.
No