Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-2989: Add background to images to improve readability in dark mode #78

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

tomwheeler
Copy link
Collaborator

What was changed

I added a white background to several images to provide contrast that will improve readability for users who have enabled dark mode.

Why?

As illustrated in EDU-2989, the images previously had transparent backgrounds. Dark lines and text in these images were difficult or impossible to read in dark mode, since that changes the page background from white to black. Since I don't use dark mode, I was unaware of the problem until a co-worker mentioned it.

Checklist

  1. Closes

EDU-2989

  1. How was this tested:

I verified that all images used in the documentation and previously had text or lines on a transparent background now have a white background to provide the required contrast regardless of whether a user has enabled dark mode.

  1. Any docs updates needed?

No

@tomwheeler tomwheeler merged commit e206668 into main Aug 28, 2024
8 checks passed
@tomwheeler tomwheeler deleted the edu-2989-image-backgrounds branch August 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants