Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding replay announcement banner 🇬🇧 #3293

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

jsundai
Copy link
Contributor

@jsundai jsundai commented Jan 14, 2025

What does this PR do?

also adding color to banner

Notes to reviewers

to reviewer: feel free to provide banner name suggestions
preview

@jsundai jsundai requested a review from a team as a code owner January 14, 2025 23:15
@jsundai jsundai changed the title Adding replay announcement banner Adding replay announcement banner 🇬🇧 Jan 14, 2025
Copy link
Contributor

@fairlydurable fairlydurable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jwahir! Thank you for making this happen.

I'm going to unblock. It looks good.

While I know you're re-using the previous version, it's small and hard to read for me. Trying to convince myself that this is because of my browser settings.

image

I checked the link, it worked great.

@jsundai
Copy link
Contributor Author

jsundai commented Jan 15, 2025

Thanks for the ready to merge tag!

@jsundai jsundai merged commit 922ad95 into main Jan 15, 2025
4 checks passed
@jsundai jsundai deleted the replay-london-announcement branch January 15, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants